Skip to content

Conversation

@caicancai
Copy link
Contributor

Problem Description:
In the original implementation, even after the limit had decreased to 0 in the previous splits, the iterator would still continue traversing thousands of subsequent intervals. Although each interval only performed the is_some_and check once, it still incurred unnecessary traversal overhead.

Solution: This optimization immediately executes break when limit == 0 is detected, ensuring that subsequent intervals are no longer traversed.

Signed-off-by: cancaicai <2356672992@qq.com>
@AdamGS AdamGS added the changelog/performance A performance improvement label Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.94%. Comparing base (4bbafe7) to head (a11e4a2).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-scan/src/repeated_scan.rs 90.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005 robert3005 merged commit fa5eeda into vortex-data:develop Jan 17, 2026
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants